-
Notifications
You must be signed in to change notification settings - Fork 602
Encapsulate Insert
and Delete
into specific structs
#1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: tison <[email protected]>
Insert
and Delete
into specific structs
Statement::Insert(insert) => { | ||
let Insert { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it matters, but just FYI you can do the same thing in the single let statement
Statement::Insert(insert) => { | |
let Insert { | |
Statement::Insert(Insert { | |
.. | |
}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comment! I'll remember this and update this snippet when I have some time. You're correct. I just follow the intuitive "refactor" :D
Pull Request Test Coverage Report for Build 8697518764Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tisonkun -- while this will require downstream changes, I think they are mechanical and will be straightforward for users and this will make it easier to manage these statements going forward.
Thanks for your review and merge! |
Signed-off-by: tison <[email protected]>
cc @alamb
This refers to #1204 where we will pull out some of the higher level enum variants into their own
Struct
s for easier use