Skip to content

Clean up nightly clippy lints #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 29, 2024

I noticed the github actions runner was marking these on PRs as the nightly clippy has gotten smarter.

So I ran cargo clippy +nightly and fixed the resulting errors

@@ -5200,7 +5200,13 @@ impl fmt::Display for CopyLegacyCsvOption {
}
}

/// `MERGE` Statement
///
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy flags empty doc comments now

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8101688641

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.881%

Totals Coverage Status
Change from base Build 8101602088: 0.0%
Covered Lines: 20203
Relevant Lines: 22989

💛 - Coveralls

@alamb alamb enabled auto-merge (squash) February 29, 2024 19:56
@alamb alamb disabled auto-merge February 29, 2024 19:56
@alamb alamb merged commit 10cc54e into apache:main Feb 29, 2024
@alamb alamb deleted the alamb/nightly_cleanup branch April 9, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants