Skip to content

Handle escape, unicode, and hex in tokenize_escaped_single_quoted_string #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JasonLi-cn
Copy link
Contributor

@JasonLi-cn JasonLi-cn commented Feb 26, 2024

@coveralls
Copy link

coveralls commented Feb 26, 2024

Pull Request Test Coverage Report for Build 8098472754

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 151 of 158 (95.57%) changed or added relevant lines in 2 files are covered.
  • 310 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.09%) to 87.881%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_postgres.rs 30 31 96.77%
src/tokenizer.rs 121 127 95.28%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_common.rs 42 97.1%
src/ast/query.rs 67 83.27%
src/parser/mod.rs 201 83.22%
Totals Coverage Status
Change from base Build 8096073891: 0.09%
Covered Lines: 20203
Relevant Lines: 22989

💛 - Coveralls

@alamb alamb changed the title refactor: tokenize_escaped_single_quoted_string Handle escape codes in tokenize_escaped_single_quoted_string Feb 29, 2024
@alamb alamb changed the title Handle escape codes in tokenize_escaped_single_quoted_string Handle escape, unicode, and hex in tokenize_escaped_single_quoted_string Feb 29, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JasonLi-cn -- sorry for the delay in review. I think this PR does more than refactor the function, so I changed the name of the PR to reflect what I think is different

I also changed the API a little more to avoid some unecessary pub (crate)

Any chance you can take a look before I merge it to make sure I got it right?

@JasonLi-cn
Copy link
Contributor Author

Thank you @JasonLi-cn -- sorry for the delay in review. I think this PR does more than refactor the function, so I changed the name of the PR to reflect what I think is different

I also changed the API a little more to avoid some unecessary pub (crate)

Any chance you can take a look before I merge it to make sure I got it right?

Thank you for reviewing this PR, and I think your modification is necessary.

@alamb alamb merged commit 4d1eecd into apache:main Feb 29, 2024
@alamb
Copy link
Contributor

alamb commented Feb 29, 2024

Thanks again @JasonLi-cn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants