-
Notifications
You must be signed in to change notification settings - Fork 612
Handle escape, unicode, and hex in tokenize_escaped_single_quoted_string
#1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle escape, unicode, and hex in tokenize_escaped_single_quoted_string
#1146
Conversation
Pull Request Test Coverage Report for Build 8098472754Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…nize_escaped_single_quoted_string
tokenize_escaped_single_quoted_string
tokenize_escaped_single_quoted_string
tokenize_escaped_single_quoted_string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @JasonLi-cn -- sorry for the delay in review. I think this PR does more than refactor the function, so I changed the name of the PR to reflect what I think is different
I also changed the API a little more to avoid some unecessary pub (crate)
Any chance you can take a look before I merge it to make sure I got it right?
Thank you for reviewing this PR, and I think your modification is necessary. |
Thanks again @JasonLi-cn |
Related to apache/datafusion#9268