Skip to content

UNLOAD, SET TBLPROPERTIES, SERDEPROPERTIES, EXECUTE USING, SET LOCATION, DELIMITED, EXTENDED / FORMATTED #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

jonathanlehto
Copy link
Contributor

Some updates, I tried to find references and included them below. I'm not all too familiar with this repo. so feedback would be appreciated.

If needed, I can look into breaking out these changes into separate PR's.

SET TBLPROPERTIES -- https://docs.databricks.com/en/sql/language-manual/sql-ref-syntax-ddl-tblproperties.html#set-tblproperties

Hive Delimited Properties -- https://spark.apache.org/docs/latest/sql-ref-syntax-hive-format.html

Hive SERDEPROPERTIES -- https://spark.apache.org/docs/3.0.1/sql-ref-syntax-ddl-create-table-hiveformat.html

Hive EXTENDED / FORMATTED -- https://docs.cloudera.com/cdw-runtime/cloud/materialized-view-commands/topics/hive_describe_materialized_view.html

Added support for DESC version of DESCRIBE

EXECUTE USING -- https://www.postgresql.org/docs/current/plpgsql-statements.html#PLPGSQL-STATEMENTS-EXECUTING-DYN

Unload -- https://docs.aws.amazon.com/redshift/latest/dg/r_UNLOAD.html
Athena only, should this be its own dialect?

Athena SET LOCATION -- https://docs.aws.amazon.com/athena/latest/ug/alter-table-set-location.html
Doesn't require SET, also may be Athena only

Included is a possible bugfix where supporting columns after partition could consume a query

@alamb
Copy link
Contributor

alamb commented Feb 29, 2024

Hi @jonathanlehto -- thank you for the contribution and I apologize for the delay in reviews.

If you could please split this PR into smaller ones for easier review I would be most appreciative -- it will be much easier for me to verify that each feature is properly tested and documented in smaller PRs rather than one large one

@alamb alamb marked this pull request as draft February 29, 2024 14:15
@alamb
Copy link
Contributor

alamb commented Feb 29, 2024

Marking as Draft to signify this PR is no longer waiting on review. Please mark it as ready for review when it is ready for another look.

@jonathanlehto
Copy link
Contributor Author

Okay, this pull request has been split into the following. I'll leave this this on draft for now

#1150
#1151
#1152
#1153
#1154
#1155
#1156
#1157

@alamb
Copy link
Contributor

alamb commented Feb 29, 2024

Okay, this pull request has been split into the following. I'll leave this this on draft for now

Thank you very much 🙏

@jonathanlehto
Copy link
Contributor Author

Most of the split pr's are in. This pr is no longer necessary as a reference, closing..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants