Test that redundant nesting is supported #108
Conversation
SELECT * FROM (((SELECT 1))) is just as valid as SELECT * FROM (SELECT 1). Add a test to ensure that we can parse the first form. Addresses a comment from apache#100.
Pull Request Test Coverage Report for Build 310
💛 - Coveralls |
There was a problem hiding this comment.
Ah, I see: unlike in the spec, TableFactor::NestedJoin can represent a non-join TableFactor in parens, so ((SELECT 1)) gets represented as NestedJoin{ base: Derived(Select...), joins: vec![] }. The spec has separate productions for ((foo NATURAL JOIN bar)) and for FROM ((SELECT 1 a))x, the latter is allowed in <query primary>.
This will probably need to be amended to support queries like (SELECT .. EXCEPT SELECT ..) UNION (SELECT .. EXCEPT SELECT ..), so it's good you took time to add more tests in this PR. Thanks!
(Note that the spec requires naming the derived queries, and MSSQL/Postgres do too, though we currently don't.)
Oh boy. That'll be fun to deal with. 🙃 |
SELECT * FROM (((SELECT 1))) is just as valid as
SELECT * FROM (SELECT 1). Add a test to ensure that we can parse the
first form.
Addresses a comment from #100.