Skip to content

Adds support for PostgreSQL "END" #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

tobyhede
Copy link
Contributor

@tobyhede tobyhede commented Nov 2, 2023

Related to #1034

Adds support for treating END as COMMIT.
END is still used as a statement delimiter, but we only check this case if expecting a statement to end.

I am not 100% sure this is the right approach, but the tests pass.

@coveralls
Copy link

coveralls commented Nov 18, 2023

Pull Request Test Coverage Report for Build 6938222562

  • 7 of 8 (87.5%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 87.706%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
src/parser/mod.rs 1 83.22%
Totals Coverage Status
Change from base Build 6937704001: -0.001%
Covered Lines: 17900
Relevant Lines: 20409

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @tobyhede 🙏

Signed-off-by: Toby Hede <[email protected]>
@alamb alamb merged commit 541d684 into apache:main Nov 21, 2023
@alamb
Copy link
Contributor

alamb commented Nov 21, 2023

Thanks again @tobyhede

serprex added a commit to PeerDB-io/sqlparser-rs that referenced this pull request Dec 11, 2023
Merge 0.40 + apache/datafusion-sqlparser-rs#1040

Upstream implemented END parsing as COMMIT on postgresql: apache/datafusion-sqlparser-rs#1035 allowing some convergence
@tobyhede tobyhede deleted the fix/postgres-end branch August 27, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants