Skip to content

Nested comments were broken by the sqlparser v0.54 release #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lovasoa opened this issue Feb 28, 2025 · 1 comment · Fixed by #1754
Closed

Nested comments were broken by the sqlparser v0.54 release #1753

lovasoa opened this issue Feb 28, 2025 · 1 comment · Fixed by #1754

Comments

@lovasoa
Copy link
Contributor

lovasoa commented Feb 28, 2025

Nested /* comments used to be parsed as such by sqlparser, but have been broken by the 0.54 release.

The following works in postgresql and mssql:

select /* /* comment */ */ 1;

and it used to be parsed correctly by sqlparser, but now is not.

Initially reported in sqlpage/SQLPage#834

@lovasoa
Copy link
Contributor Author

lovasoa commented Feb 28, 2025

Nested comments are explicitly supported in Microsoft SQL Server: https://learn.microsoft.com/en-us/sql/t-sql/language-elements/slash-star-comment-transact-sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant