Skip to content

Corrected fix for missing namespace 'firebase' #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

taylorjason2016
Copy link

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • e2e tests included?: (yes/no; required for multi-function/multi-class changes)
  • In a clean directory, npm install, npm run build, and npm test run successfully? (yes/no; required)

Description

Code sample

}
}
If you run into this error while trying to invoke `ng serve`, you need to update to the correct types with the following commands (from the root of a new project):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taylorjason2016 Really. I never created the directory as mentioned below and everything works as expected.

@katowulf @davideast : FYI

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukesh51
I've confirmed on multiple machines and a fresh Ubuntu VM. Also reported by others in my company. Is it possible this used to be an issue and therefore it's a version problem?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taylorjason2016 Not sure if it's a version problem. But i can confirm, that I did a fresh install on Windows 7 machine, trying to look into an issue and I didn't have to create any directories as per your PR request. I may try doing an install on Ubuntu to confirm.

Copy link
Contributor

@mukesh51 mukesh51 Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taylorjason2016 I can confirm now, that the PR you mentioned is not required. Just completed a fresh install on Ubuntu 16.0.4 LTS (Amazon EC2 Instance) and everything worked as expected, as mentioned in the install guide.

Note:- There seems to be a bug with installation of angular-cli on Ubuntu_16_0_4 itself, but that will be out of scope of angularFire2. I'll dig a little more, before reporting it. Hope this helps.

@davideast
Copy link
Collaborator

davideast commented Dec 27, 2016

Thanks for your PR, but this should be fixed with #681 :)

@davideast davideast closed this Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants