Update typings installation instructions. #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor update instructs users to install the firebase3 typings file into
typings.jsoninstead of intotsconfig.js. I believe that this method is better because some projects use the"excludes"property in tsconfig (I encountered this in an Ionic v2 setup), which is mutually exclusive to the"files"property.If users do not know this, they can inadvertently begin including files that they had been meaning to exclude. Otherwise they might think they have to refactor their globbing pattern to use with
"files"instead of"exclude", which isn't necessary if the typings are left out of tsconfig.I shared this solution on issue #234 (comment) and it seems to have worked for other people as well.