fix(providers): remove DEFAULT_ DEFAULT_FIREBASE_REF and DEFAULT_FIRE… #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BASE BREAKING CHANGE: The tokens to inject the root firebase url and reference have changed from DEFAULT_FIREBASE -> FirebaseUrl DEFAULT_FIREBASE_REF -> FirebaseRef Closes angular#25
|
LGTM |
| ... | ||
| class MyComponent { | ||
| constructor(@Inject(DEFAULT_FIREBASE_REF) ref:Firebase) { | ||
| constructor(@Inject(FirebaseRef) ref:Firebase) { |
There was a problem hiding this comment.
definitely worth considering the ergonomics here - @Inject(FirebaseRef) ref:Firebase vs ref:Firebase vs ref:FirebaseRef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…BASE
BREAKING CHANGE:
The tokens to inject the root firebase url and reference have changed from
DEFAULT_FIREBASE -> FirebaseUrl
DEFAULT_FIREBASE_REF -> FirebaseRef
Closes #25