fix(analytics): Fix custom data layer function #2594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change arrow function to a normal function to use the arguments object as described in the gtag documentation. That way, analytics sends data back to Google again. Fixes #2505
|
Great catch! I'll merge and cut in the next RC, thanks. |
jamesdaniels
approved these changes
Sep 24, 2020
|
Cut in |
Splaktar
reviewed
Sep 24, 2020
Comment on lines
+69
to
+72
| // tslint:disable-next-line: only-arrow-functions | ||
| gtag = (window[GTAG_FUNCTION_NAME] as any) || (function(..._args: any[]) { | ||
| (window[DATA_LAYER_NAME] as any).push(arguments); | ||
| }); |
There was a problem hiding this comment.
We really should have a comment in here that warns developers/contributors to making this an arrow function causes GA to break completely.
In the current state, it's likely that someone will come in and "fix" this breaking GA again.
There was a problem hiding this comment.
You are right, I can make and submit another PR when I have free time
|
For reference, this regression was introduced in 23e2f1e. |
Capelinha
added a commit
to Capelinha/angularfire
that referenced
this pull request
Oct 7, 2020
Adding a warning in the code so no one can turn the gtag function into an arrow function. PR angular#2594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change arrow function to a normal function to use the arguments object as described in the gtag documentation. That way, analytics sends data back to Google again.
Fixes #2505
Checklist
yarn install,yarn testrun successfully? yesDescription
Since updating to version 6.0.1, analytics no longer sends data to the Firebase Console. Analyzing and debugging this lib I realized that the code that defines a custom datalayer in gtag has been changed from a normal function to an arrow function.
After some research I learned that 'arguments' is not an array, it is actually an object that behaves like an array and contains more information besides indexes.
I'm not sure what the analytics need for this 'arguments' object, but I know that by making this change, the analytics sent the data back to the Console.