Update on the example app #2554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example didn't work in my Angular 10 app as `auth` was `undefined`. It took some forum digging to find the error.
|
@tomcatmwi @oavila81 @jamesdaniels |
|
Also there is an even earlier PR that tries to fix this doc: #2483 |
Splaktar
reviewed
Sep 24, 2020
| @@ -30,7 +30,7 @@ export class AppComponent { | |||
| constructor(public auth: AngularFireAuth) { | |||
| } | |||
| login() { | |||
| this.auth.signInWithPopup(new auth.GoogleAuthProvider()); | |||
| this.auth.signInWithPopup(new firebase.auth.GoogleAuthProvider()); | |||
There was a problem hiding this comment.
I think that the approach in PR #2483 is better. I.e.
this.afAuth.auth.
|
Thanks, addressed in another PR. Docs should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? noDescription
The example code in the docs didn't work on Angular 10 as
authwas alwaysundefined. It took some forum digging to find the error.Code sample