fix(): FirebaseApp Class should not implement app.App #2060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While giving us a bit more type safety in development, implementing app.App allows the Firebase JS SDK to break our builds in minor releases. Which has bit us more than once. I do not believe this is worth keeping around any longer. Fixes #2059
|
@davideast Heads up, the tests are stuck on the Firestore flake. I'm going to admin override & merge. |
peterennis
added a commit
to peterennis/angularfire2
that referenced
this pull request
May 3, 2019
fix(): FirebaseApp Class should not implement app.App (angular#2060)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
While giving us a bit more type safety in development, implementing
app.Appallows the Firebase JS SDK to break our builds in minor releases. Which has bit us more than once.I do not believe this is worth keeping around any longer.
Code sample
No API change.