Skip to content

refactor: move to Angular CLI based repository #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sarunint
Copy link
Contributor

Checklist

Description

Move to Angular CLI-based repository as discussed in #2021.

Code sample

N/A

@jamesdaniels this is just a PoC. You can run ng build but not ng test yet. Also @angular/fire/firebase-node is not moved yet. PTAL

@sarunint
Copy link
Contributor Author

Note: currently, this PR is in all one big commit. But I'm happy to split it up later.

@jamesdaniels
Copy link
Member

jamesdaniels commented May 31, 2019

Adding @mgechev as we've been talking about switching this lib over to Bazel.

Thoughts on switching over to packagr?

@mgechev
Copy link
Member

mgechev commented Jun 2, 2019

Ideally, we'll switch the CLI to Bazel just by replacing the builder in angular.json and this shouldn't impact AngularFire. If this PR leads to significant simplification of the build process, IMO, it's worth it.

@jamesdaniels
Copy link
Member

@sarunint thanks for getting the ball rolling here. I'm taking up the work in #2117 as the slow builds are getting frustrating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants