chore(): Shoring up @Optional types #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davideast Ready for review. Don't merge, if approved; as I'm targeting this for the 5.2 release. |
peterennis
added a commit
to peterennis/angularfire2
that referenced
this pull request
Mar 9, 2019
chore(): Shoring up @optional types (angular#2014)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? (yes/no; required)Description
@Optional()injections are actually passed through asnull(rather thanundefined, if not present), this has lead to a couple bugs in the past. Just shoring all these up to avoid similar mistakes in the future.Code sample
No API change.