Update messaging.ts #1939
Closed
Update messaging.ts #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a breaking bug. It's not calling firebase/messaging correctly.
jamesdaniels
requested changes
Nov 6, 2018
|
@jamesdaniels the error is not building the application, the application breaks when it's running and it calls Messaging. He has the same problem: #1938 (comment) |
JeMeister
commented
Nov 6, 2018
|
The error was solved deleting the folder node_modules/@angular and installing again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue number for this PR: #1938 (required)
Docs included?: no (yes/no; required for all API/functional changes)
Test units included?: no (yes/no; required)
In a clean directory, yarn install, yarn test run successfully? yes (yes/no; required)
Description
This resolves the error using messaging. Now, it is calling firebase/messaging correctly using require().