-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Firebase 5.10 timestampInSnapshots error #2050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Comments
ron4548
added a commit
to ron4548/angularfire2
that referenced
this issue
Apr 20, 2019
Change the condition that determines whether timestampsInSnapshots setting is set to true. This is done to order to comply with multiple digits minor versions of firebase sdk. For example: version 5.10.0 is greater than 5.8.0 fixes angular#2050
jamesdaniels
pushed a commit
that referenced
this issue
Apr 25, 2019
Change the condition that determines whether timestampsInSnapshots setting is set to true. This is done to order to comply with multiple digits minor versions of firebase sdk. For example: version 5.10.0 is greater than 5.8.0 fixes #2050
@jamesdaniels Any idea when this change will be included in a release, or a suggested workaround other than downgrading firebase to 5.9? Thanks for the work on solving this, and the @angular/fire package in general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version info
Angular: 7.2.13
Firebase: 5.10.0
AngularFire: 5.1.2
Other (e.g. Ionic/Cordova, Node, browser, operating system):
How to reproduce these conditions
Just use the AngularFireStore module with the specified versions, and the error appears.
Debug output
Expected behavior
Error should not be displayed according to the following line (firestore.ts:22):
export const DefaultFirestoreSettings = (parseFloat(SDK_VERSION) < 5.8 ? {timestampsInSnapshots: true} : {}) as Settings;
https://github.com/angular/angularfire2/blob/master/src/firestore/firestore.ts
Actual behavior
Since the version is parsed to a float, version 5.10 is considered as 5.1 and therefore the timestampsInSnapshots setting is enabled explicitly.
The text was updated successfully, but these errors were encountered: