This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($location/$browser): prevent infinite digests on empty hash changes #9903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function getHash(url) { | ||
| var index = url.indexOf('#'); | ||
| return index===-1 ? '' : url.substr(index+1); | ||
| } |
There was a problem hiding this comment.
I guess that this function should be inside browser.js but there were other helper function here.
There was a problem hiding this comment.
Missing spaces around === and + 😃
|
this could use some tests --- I think it's probably a suitable place to use the new e2e test harness (since it depends on being able to change location --- you should be able to try changing to |
petebacondarwin
force-pushed
the
empty-hash-fix
branch
from
a01e9af to
382efe4
Compare
The url is the same whether or not there is an empty `#` marker at the end. This prevents unwanted digest turns. Closes angular#9635
petebacondarwin
force-pushed
the
empty-hash-fix
branch
from
382efe4 to
c42e887
Compare
|
@caitp - yes you are right. I was struggling to test this in an non-artificial way. I'll give it a go tomorrow. |
|
at a glance it looks okay, but $location is a bit complicated, so I want to see it work before I say lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9635