Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fixed comment which was copy&paste from dgeni example #9798

Closed
wants to merge 1 commit into from

Conversation

ChristianKohler
Copy link
Contributor

No description provided.

// Create and export a new Dgeni package called dgeni-example. This package depends upon
// the jsdoc and nunjucks packages defined in the dgeni-packages npm module.
// Create and export a new Dgeni package called angularjs. This package depends upon
// the ngdoc,nunjucks and examples packages defined in the dgeni-packages npm module.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is missing after the comma.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't amend that --- one of you can submit a subsequent PR if it bothers you that much, but honestly nobody reads that file ever o_o

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@caitp
Copy link
Contributor

caitp commented Oct 27, 2014

I don't think this really matters, but if it makes people feel better then I'm all for it I guess?

@ChristianKohler
Copy link
Contributor Author

@caitp Sure, but why leave a wrong comment if it can be fixed.
@mary-poppins I signed the CLA.

@caitp
Copy link
Contributor

caitp commented Oct 27, 2014

because I don't think it's wrong, it's just showing where the config originally came from. it's not like it's visible to anyone who isn't inspecting it :p

@ChristianKohler
Copy link
Contributor Author

The comment says ".. package called dgeni-example.." and it actually creates a packages called "angularjs". Did confuse me for a second.

caitp pushed a commit that referenced this pull request Oct 27, 2014
@caitp caitp closed this in 99ec8d6 Oct 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants