-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Fixed comment which was copy&paste from dgeni example #9798
Conversation
// Create and export a new Dgeni package called dgeni-example. This package depends upon | ||
// the jsdoc and nunjucks packages defined in the dgeni-packages npm module. | ||
// Create and export a new Dgeni package called angularjs. This package depends upon | ||
// the ngdoc,nunjucks and examples packages defined in the dgeni-packages npm module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A space is missing after the comma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't amend that --- one of you can submit a subsequent PR if it bothers you that much, but honestly nobody reads that file ever o_o
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
I don't think this really matters, but if it makes people feel better then I'm all for it I guess? |
@caitp Sure, but why leave a wrong comment if it can be fixed. |
because I don't think it's wrong, it's just showing where the config originally came from. it's not like it's visible to anyone who isn't inspecting it :p |
The comment says ".. package called dgeni-example.." and it actually creates a packages called "angularjs". Did confuse me for a second. |
It makes people happy, so why not Closes #9798
No description provided.