docs(tutorial/11 - REST and Custom Services): describe your change... #9775
Conversation
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
| @@ -276,7 +276,7 @@ describe('PhoneCat controllers', function() { | |||
|
|
|||
| You should now see the following output in the Karma tab: | |||
|
|
|||
| <pre>Chrome 22.0: Executed 4 of 4 SUCCESS (0.038 secs / 0.01 secs)</pre> | |||
| <pre>Chrome 22.0: Executed 5 of 5 SUCCESS (0.038 secs / 0.01 secs)</pre> | |||
There was a problem hiding this comment.
You should also update the duration stats to make it more realistic :P
|
I can never tell if these fixes are correct or not, because i'm not sure if the text is supposed to reflect the "before" case or the "after" case. But I'll just take your word for it this time. LGTM |
|
Oh, and please sign the CLA --- it's hard to imagine why we need it for docs-only fixes, but it would be very helpful if you sign it. https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#signing-the-cla |
Since there came in one more Test, the unit-test should show 5 of 5 correct tests.
In my case i had to restart "npm test" to get this right ...