This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($templateCache): clarify inline template #9741
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -369,7 +369,7 @@ function $CacheFactoryProvider() { | |||
| * ``` | |||
| * | |||
| * **Note:** the `script` tag containing the template does not need to be included in the `head` of | |||
| * the document, but it must be below the `ng-app` definition. | |||
| * the document, but it must be inside `ng-app` tag. Otherwise the template will be ignored. | |||
marcin-wosinek
force-pushed
the
patch-2
branch
from
e388f28 to
39740e0
Compare
| @@ -369,7 +369,7 @@ function $CacheFactoryProvider() { | |||
| * ``` | |||
| * | |||
| * **Note:** the `script` tag containing the template does not need to be included in the `head` of | |||
| * the document, but it must be below the `ng-app` definition. | |||
| * the document, but it must be inside tag with `ng-app`. Otherwise the template will be ignored. | |||
There was a problem hiding this comment.
how about "must be a descendant of the @{link ng.$rootElement $rootElement} (IE, element with ng-app attribute), otherwise the template will be ignored."
There was a problem hiding this comment.
looks pretty cool. Updating..
Current doc doesn't state required tag location clear enough. It was [stack overflow|http://stackoverflow.com/a/16125138] where I've found that requirement
marcin-wosinek
force-pushed
the
patch-2
branch
from
39740e0 to
b438744
Compare
|
just gonna see how that renders, because I might have got the syntax wrong =P it's probably good though |
|
yeah should be |
caitp
pushed a commit
that referenced
this pull request
Oct 22, 2014
Current doc doesn't state required tag location clear enough. It was [stack overflow|http://stackoverflow.com/a/16125138] where I've found that requirement Closes #9741
|
merg'd! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current doc doesn't state required tag location clear enough. It was [stack overflow|http://stackoverflow.com/a/16125138] where I've found that requirement