docs($compile): improve documentation on directive $scope usage #9727
Conversation
| * same element request a new scope, only one new scope is created. The new scope rule does not | ||
| * apply for the root of the template since the root of the template always gets a new scope. | ||
| * **If set to `true`,** then a new scope will be created for this directive, otherwise it won't | ||
| * create a new scope and use the scope of its parent. If multiple directives on the same element |
There was a problem hiding this comment.
incorrect --- if scope is an object (but not true), it will still create a new scope.
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
Currently I have no idea why the build fails. On my machine unit and e2e tests can all be executed successfully. Any ideas what I'm doing wrong? |
|
@psysp it was a flake, your change didn't break anything. Can you rebase this PR and squash commits? Also please make sure to sign the CLA --- unfortunately, while we used to be able to accept docs PRs with no CLA signature, we do require a signature now :( (I'm not happy about it either, but the good news is you only need to sign it once for all google open source projects!) |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Add information about the behavior of several directives especially of their scopes when applied on a single element. Add explanation for the different values the scope property of the directive declaration can have. Close #5761
|
CLAs look good, thanks! |
|
Commits are squashed, cla is signed. |
| * | ||
| * **If set to `{}` (object hash),** then a new "isolate" scope is created. The 'isolate' scope differs from | ||
| * * **`false`:** No scope will be created for the directive. The directive will use its parent's scope. |
There was a problem hiding this comment.
this implies that false is somehow different from any other non-true, non-object value. The only cases that matter are true and object
Add information about the behavior of several directives especially of their scopes when applied on a single element.
Close #5761