style: enforce spaces after keywords, add spaces

[hzoo]

Moving the requireSpaceAfterKeywords rule to jscs with associated changes.

Is it preferred to explicitly specify the keywords in an array?

Or use requireSpaceAfterKeywords = true
which is equivalent to requireSpaceAfterKeywords = [ 'do', 'for', 'if', 'else', 'switch', 'case', 'try', 'catch', 'void', 'while', 'with', 'return', 'typeof', 'function'];

Although it doesn't make sense for function.

cc: @caitp

[caitp]

catch (e) always looks weird to me, I'm not a fan of that style =\

[hzoo]

Yeah I agree. Similar to function (e), switch (e), void (e), so keywords that have parens right after.

[gkalpak]

I like it :)
The only thing left that I would change in Angular's style is adding a space after function (in anonynous functions) =)

[caitp]

I'd rather function were trailed immediately by parentheses*, unless it's a named function --- can jscs enforce that?

(I meant parentheses, not braces**)

[pkozlowski-opensource]

+1

[hzoo]

Yeah can be done.

For all functions (declaration, named expression, anon expression)

"disallowSpacesInFunction": {
    "beforeOpeningRoundBrace": true
}

If you want to be specific:

disallowSpacesInFunctionDeclaration
disallowSpacesInNamedFunctionExpression
disallowSpacesInAnonymousFunctionExpression

You can also enforce a space before the parentheses.

"requireSpacesInFunction": {
    "beforeOpeningCurlyBrace": true
}

So with both rules it should be

function a() {

}

var a = function() {

}

var a = function a() {

}

[caitp]

cool, that sounds like a good setup

[gkalpak]

People, save the space in anonymous functions !!!

[caitp]

lgtm

[caitp]

Is it preferred to explicitly specify the keywords in an array?

Yes, this is fine

[caitp]

If you care to adjust the jscs rules to implement the comments I suggested above, please send another one =)

[gkalpak]

Is there a way to enforce no whitespace after ( and before ) ?

[shahata]

+1

[hzoo]

Yeah using "disallowSpacesInsideParentheses": true.

Valid

if (attrs[attrName]) {

Invalid

if ( attrs[attrName]) {
if (attrs[attrName] ) {
if ( attrs[attrName] ) {

[shahata]

Truthfully I'd really prefer to always have a space after reserved words, including function and catch, but since the de-facto standard in angular is to avoid it I guess we can leave it as is...

[gkalpak]

If I remember correctly, last time I checked the function()/function () ratio was 2:1, so I wouldn't call it the "de-facto standard".
That said, I do find the function () (with space) more consistent and intuitive.

[hzoo]

After doing some testing with jscs,

Checking only function declarations: for function a (e) { };, got 10.
Checking only function declarations: for function a(e) {};, got 1698.

Checking only anonymous function expressions: for function (e), got 1121.
Checking only anonymous function expressions: for function(e), got 9159.

Checking only named function expressions: for function a(e), got 131.
Checking only named function expressions: for function a (e), got 1.

So based on majority it would be

//declaration
function a() {

}
//anon
var a = function() {

};
//named
var a = function a() {

};

But yeah could go either way for anon func expressions since dropping the name in a named function expression would leave the space still there.