Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Make templates consistent #9670

Closed
wants to merge 1 commit into from
Closed

Make templates consistent #9670

wants to merge 1 commit into from

Conversation

Starojitski
Copy link
Contributor

In Lession 1 template has phone names within span element, while in lession 2 the name is directly within the wrapper div

In Lession 1 template has phone names within ```span``` element, while in lession 2 the name is directly within the wrapper ```div```
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@caitp
Copy link
Contributor

caitp commented Oct 18, 2014

In the actual tutorial app, we don't have <span> tags there --- I think it makes more sense to match the tutorial

@caitp
Copy link
Contributor

caitp commented Oct 18, 2014

@petebacondarwin should we change the tutorial to have span tags?

@petebacondarwin
Copy link
Contributor

They get added in the phoncat project at step 4 - angular/angular-phonecat@749230e
We should probably just fix up steps 2 and 3

@petebacondarwin
Copy link
Contributor

I added the <span> tags back into steps 2 and 3

@Starojitski
Copy link
Contributor Author

The same is applicable to step 3, which is now the only step without spans around phone names

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants