Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngEventDirs): update remarks on behavior #9640

Closed
wants to merge 1 commit into from

Conversation

mernen
Copy link
Contributor

@mernen mernen commented Oct 16, 2014

This comment states that events are configured not to propagate, but that hasn't been the case since 1752c8c, over 2.5 years ago(!). This is a minor tweak to the block, also removing the part that's too specific to onclick.

The event directives haven't stopped propagation by default in a long time.
If that behavior is desired, the handler may use the provided `$event` to call:

    $event.stopPropagation();
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@IgorMinar
Copy link
Contributor

lgtm. do you mind signing CLA please?

@IgorMinar IgorMinar added this to the 1.3.1 milestone Oct 16, 2014
@mernen
Copy link
Contributor Author

mernen commented Oct 16, 2014

I did sign it years ago, but I've signed again anyway.

@caitp
Copy link
Contributor

caitp commented Oct 16, 2014

I'm not sure this passage is actually rendered on the docs site, but it basically looks okay --- I will make sure the CLA was signed, @mernen just to be clear, you've signed with the email from https://github.com/angular/angular.js/pull/9640.patch right?

caitp pushed a commit that referenced this pull request Oct 16, 2014
The event directives haven't stopped propagation by default in a long time.
If that behavior is desired, the handler may use the provided `$event` to call:

    $event.stopPropagation();

Closes #9640
@caitp caitp closed this in 47e15aa Oct 16, 2014
@caitp
Copy link
Contributor

caitp commented Oct 23, 2014

CLA verified by Max Sills and George Lu

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants