This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($templateRequest): ignore JSON Content-Type header and content #9619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, if there is a Content-Type header with the string "application/json", or else the content looks sort of JSON-y, $http will attempt to deserialize the JSON into an object. $templateRequest is intended to request markup, and as such should never attempt to parse JSON, regardless of the headers or shape of the content. Closes angular#5756
| $templateRequest('a.html').then(spy); | ||
| $httpBackend.flush(); | ||
| expect(spy).toHaveBeenCalledOnce(); | ||
| expect(spy.argsForCall[0][0]).toBe('{{text}}'); |
There was a problem hiding this comment.
toHaveBeenCalledOnceWith('{{text}}')
| transformResponse.splice(idx, 1); | ||
| } else if (transformResponse === httpResponseTransform) { | ||
| transformResponse = null; | ||
| } |
There was a problem hiding this comment.
updated to avoid breaking change
|
otherwise lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, if there is a Content-Type header with the string
"application/json", or else the content looks sort of JSON-y, $http will
attempt to deserialize the JSON into an object. $templateRequest is intended
to request markup, and as such should never attempt to parse JSON, regardless
of the headers or shape of the content.
/CC @IgorMinar should be quick to review
Closes #5756