Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore($$raf) Remove support for moz prefixed requestAnimationFrame #9577

Closed
wants to merge 1 commit into from

Conversation

realityking
Copy link
Contributor

According to can I use this would drop support for the following browsers:

  • Firefox 22
  • Chrome 23
  • Safari 6
  • iOS 6.1

Note, they don't have data on Blackberry 10.1 (where it's prefixed) and 10.2 (where it's unprefixed).

This is also the same level of support as provided by jQuery.

@realityking
Copy link
Contributor Author

According to #6526 and c839f78 Android 4.3 would still need a vendor prefix. Outside of AngularJS issues/commits I could find no evidence that Android 4.3 even supports rAF. Does anyone have access to a device running that version who could check?

@Traxmaxx
Copy link
Contributor

@realityking Checked on a Android 4.2.2 device inside the WebView through Cordova 3.5.0-0.2.7:
$window.webkitRequestAnimationFrame and $window.webkitCancelRequestAnimationFrame are defined. Will check with Android 4.3 tomorrow.

Update: WebView on Android 4.3 has $window.webkitRequestAnimationFrame and $window.webkitCancelRequestAnimationFrame defined too.

This drops support for Firefox 22 and older.
@realityking
Copy link
Contributor Author

Well that sucks. Thank you very much @Traxmaxx.

I've modified the commit to only remove support for the moz prefix, not sure if that's worth it.

@realityking
Copy link
Contributor Author

Could someone review or close this?

@googlebot
Copy link

CLAs look good, thanks!

@realityking realityking changed the title chore($$raf) Remove support for prefixed requestAnimationFrame chore($$raf) Remove support for moz prefixed requestAnimationFrame Dec 9, 2014
@caitp
Copy link
Contributor

caitp commented Dec 9, 2014

@matsko what do you think? FF22 was never an ESR release, so there aren't likely to be any large pools of users on it

@caitp
Copy link
Contributor

caitp commented Dec 9, 2014

@realityking do you think you could find the mozilla bug where the prefix was dropped? it would be good to include that in the commit message to help justify this

@caitp
Copy link
Contributor

caitp commented Dec 9, 2014

https://bugzilla.mozilla.org/show_bug.cgi?id=909154 I guess I misread this bug, the prefix is not dropped yet, but they want to remove it --- so we probably should land this

@caitp caitp modified the milestones: 1.3.x, Backlog Dec 9, 2014
@caitp caitp removed the post-1.3.0 label Dec 9, 2014
@matsko
Copy link
Contributor

matsko commented Dec 10, 2014

LGTM

@caitp caitp closed this in aac3c4a Dec 10, 2014
@realityking realityking deleted the raf branch January 14, 2015 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants