feat($parse): handle Infinity #9504

btford · 2014-10-08T23:02:37Z

caitp · 2014-10-09T00:41:48Z

test/ng/parseSpec.js

+      it('should evaluate Infinity', function() {
+        expect(scope.$eval("Infinity")).toBe(Infinity);
+        expect(scope.$eval("a=Infinity")).toBe(Infinity);
+        expect(scope.a).toBe(Infinity);


Add test for -Infinity

caitp · 2014-10-09T00:44:04Z

It's weird to add this but not NaN--- but it should be a good way to do it. Make sure obj.Infinity works right too imo

IgorMinar · 2014-10-09T07:01:09Z

I dunno. Either add NaN or don't do this at all.

What happens when you override Infinity via Infinity=42?

caitp · 2014-10-09T09:41:57Z

What happens when you override Infinity via Infinity=42?

shouldn't be able to afaik

V8 version 3.30.0 (candidate) [console: dumb]
d8> Infinity = 52
52
d8> Infinity
Infinity
d8> 

d8> this.Infinity = 52
52
d8> Infinity
Infinity
d8> this.Infinity
Infinity
d8>

Same in spidermonkey and JSC, basically you just can't modify Infinity in the global object

In the parser's case, that should result in writing to the Infinity property in scope though..

Closes angular#9492

btford · 2014-10-10T19:24:19Z

updated

caitp · 2014-10-10T19:26:52Z

test/ng/parseSpec.js

+        expect(scope.$eval("obj.NaN = 43")).toBe(43);
+        expect(scope.obj.NaN).toBe(43);
+      });
+


Last thing, can we add a test that

$eval('Infinity = x'); will actually assign $scope.Infinity rather than global Infinity? (and maybe, if $scope.Infinity is defined, it should shadow window.Infinity? --- maybe that's more complicated than people want)

Allow user-defined literals. Close: angular#9504 Close: angular#9492

btford added the In Progress label Oct 8, 2014

mary-poppins added cla: yes and removed cla: no labels Oct 8, 2014

caitp reviewed Oct 9, 2014
View reviewed changes

btford force-pushed the feat-parse-infinity branch 2 times, most recently from 71b6cb0 to 90e588a Compare October 9, 2014 00:56

btford force-pushed the feat-parse-infinity branch from 90e588a to 61289a5 Compare October 9, 2014 18:47

tbosch self-assigned this Oct 9, 2014

tbosch added this to the Backlog milestone Oct 9, 2014

tbosch added component: $parse type: bug frequency: low labels Oct 9, 2014

tbosch removed their assignment Oct 9, 2014

jeffbcross force-pushed the master branch 2 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:38

btford force-pushed the feat-parse-infinity branch from 61289a5 to 3afe421 Compare October 10, 2014 17:51

feat($parse): handle Infinity and NaN

595cc2e

Closes angular#9492

btford force-pushed the feat-parse-infinity branch from 3afe421 to 595cc2e Compare October 10, 2014 19:17

caitp reviewed Oct 10, 2014
View reviewed changes

petebacondarwin force-pushed the master branch from 4dd5a20 to 998c61c Compare October 19, 2014 10:58

Narretz force-pushed the master branch from 70049ae to b77e14b Compare January 16, 2016 21:59

lgalfaso added a commit to lgalfaso/angular.js that referenced this pull request Mar 7, 2016

feat($parse): Allow user-defined literals

b56ec64

Allow user-defined literals. Close: angular#9504 Close: angular#9492

lgalfaso mentioned this pull request Mar 7, 2016

feat($parse): Allow user-defined literals #14194

Closed

3 tasks

lgalfaso added a commit to lgalfaso/angular.js that referenced this pull request Mar 7, 2016

feat($parse): Allow user-defined literals

4aa1e43

Allow user-defined literals. Close: angular#9504 Close: angular#9492

lgalfaso added a commit to lgalfaso/angular.js that referenced this pull request Mar 8, 2016

feat($parse): Allow user-defined literals

cfbabc5

Allow user-defined literals. Close: angular#9504 Close: angular#9492

lgalfaso added a commit to lgalfaso/angular.js that referenced this pull request Mar 12, 2016

feat($parse): Allow user-defined literals

5584957

Allow user-defined literals. Close: angular#9504 Close: angular#9492

lgalfaso closed this in 81150ac Mar 13, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat($parse): handle Infinity #9504

feat($parse): handle Infinity #9504

btford commented Oct 8, 2014

caitp Oct 9, 2014

btford Oct 9, 2014

caitp commented Oct 9, 2014

IgorMinar commented Oct 9, 2014

caitp commented Oct 9, 2014

btford commented Oct 10, 2014

caitp Oct 10, 2014

feat($parse): handle Infinity #9504

feat($parse): handle Infinity #9504

Conversation

btford commented Oct 8, 2014

caitp Oct 9, 2014

Choose a reason for hiding this comment

btford Oct 9, 2014

Choose a reason for hiding this comment

caitp commented Oct 9, 2014

IgorMinar commented Oct 9, 2014

caitp commented Oct 9, 2014

btford commented Oct 10, 2014

caitp Oct 10, 2014

Choose a reason for hiding this comment