This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore($sniffer): Remove remnants of separate documentMode handling #9496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added
browser: IE8
browser: IE9
browser: IE10
browser: IE11
frequency: low
component: misc core
and removed
frequency: low
labels
| @@ -731,7 +731,7 @@ function $SceProvider() { | |||
| $parse, $sniffer, $sceDelegate) { | |||
| // Prereq: Ensure that we're not running in IE8 quirks mode. In that mode, IE allows | |||
| // the "expression(javascript expression)" syntax which is insecure. | |||
| if (enabled && $sniffer.msie && $sniffer.msieDocumentMode < 8) { | |||
| if (enabled && $sniffer.msie < 8) { | |||
There was a problem hiding this comment.
This can probably be completely removed, as per the above comment it's to support "IE8 quirks mode".
There was a problem hiding this comment.
This applies to IE9/IE10/IE11 quirks mode AFAIK. Perhaps I should just change the comment.
|
The only failing tests concern |
|
lgtm |
mgol
force-pushed
the
oldie-sniffer
branch
2 times, most recently
from
57694e8 to
42ed9e7
Compare
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 8, 2014
Since msie is now set to document.documentMode, it's not necessary to keep the documentMode in a separate property. Closes angulargh-9496
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 8, 2014
Since msie is now set to document.documentMode, it's not necessary to keep the documentMode in a separate property. Closes angulargh-9496
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 8, 2014
Since msie is now set to document.documentMode, it's not necessary to keep the documentMode in a separate property. Also, msie is a variable global to Angular source so there's no need to replicate it in $sniffer. Closes angulargh-9496
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 8, 2014
Since msie is now set to document.documentMode, it's not necessary to keep the documentMode in a separate property. Also, msie is a variable global to Angular source so there's no need to replicate it in $sniffer. Closes angulargh-9496
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
abdaab7 to
30996f8
Compare
mgol
added a commit
to mgol/angular.js
that referenced
this pull request
Oct 8, 2014
Since msie is now set to document.documentMode, it's not necessary to keep the documentMode in a separate property. Also, msie is a variable global to Angular source so there's no need to replicate it in $sniffer. Closes angulargh-9496
Since msie is now set to document.documentMode, it's not necessary to keep the documentMode in a separate property. Also, msie is a variable global to Angular source so there's no need to replicate it in $sniffer. Closes angulargh-9496
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since msie is now set to document.documentMode, it's not necessary to keep
the documentMode in a separate property.