This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(select): make ctrl.hasOption method consistent #9262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ]; | ||
| scope.robot = 'r2d2'; | ||
|
|
||
| compile('<select ng-model="robot" ' + |
There was a problem hiding this comment.
can we also have a version of this test for select-multiple? I don't see why the patch wouldn't work there, but it would be good to verify it
|
the fix itself looks good to me, adding the extra test is up to you, I don't think it should block landing it |
btford
force-pushed
the
fix-select-ctrl
branch
from
2568786 to
f6b4a61
Compare
|
Added another test. I think this is ready to merge. |
|
still lgtm |
|
Landed as 2bcd02d. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a WIP
Closes #8761