Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Clarify behavior when providing undefined or null value to angular.forEach #9142

Closed
wants to merge 1 commit into from

Conversation

Trendy
Copy link

@Trendy Trendy commented Sep 18, 2014

Doc update to satisfy #9062

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Trendy
Copy link
Author

Trendy commented Sep 18, 2014

Oops, committed from my work laptop, should be fixed :neckbeard:

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@caitp
Copy link
Contributor

caitp commented Sep 18, 2014

I guess this is okay --- could you please linewrap at 100 columns and ping me? thanks

@caitp caitp self-assigned this Sep 18, 2014
@caitp caitp added this to the Backlog milestone Sep 18, 2014
@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from cad9560 to f294244 Compare October 2, 2014 22:09
@jeffbcross jeffbcross force-pushed the master branch 4 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:38
@caitp
Copy link
Contributor

caitp commented Oct 14, 2014

well it's been a while and I haven't heard back! I guess I'll make the change myself grumble (just kidding about the grumbling!)

@caitp
Copy link
Contributor

caitp commented Oct 14, 2014

merg'd~

@caitp caitp closed this in 6502ab0 Oct 14, 2014
@Trendy
Copy link
Author

Trendy commented Oct 14, 2014

derp
Sorry @caitp I completely spaced doing this! Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants