chore(ngCsp): add e2e tests #9136
Conversation
| expectNoErrors(); | ||
| }); | ||
|
|
||
| it('should throw and report an error when using "eval"', function() { |
There was a problem hiding this comment.
do all the browsers we support respect CSP headers? I'm just not sure about safari 6
There was a problem hiding this comment.
Safari 6 does with a prefix: http://caniuse.com/#feat=contentsecuritypolicy
There was a problem hiding this comment.
Looks like IE9 does not, which is a problem for travis. IE10/11 also use prefixed headers :( Just skip the test if ie is detected?
There was a problem hiding this comment.
Yes, we need to do feature detection for IE9, but should keep testing IE10/11.
| var evilBtn = element(by.id('evil')); | ||
| var evilError = element(by.id('evilError')); | ||
|
|
||
| function getAndClearSevereErrors() { |
There was a problem hiding this comment.
Not sure how I feel about this; if I understand correctly, this clears all errors, but returns only the severe ones?
There was a problem hiding this comment.
Yes. Ignores warnings about css problems, ...
Right now protractor just ignores the errors...
Also changes `connect:devserver` and `connect:testserver` to conditionally serve files with csp headers when the path contains `.csp` somewhere. Depends on angular/dgeni-packages#70 to be merged and updated dgeni-packages to be included in angular.js
Also changes
connect:devserverandconnect:testserverto conditionally serve files with csp headers when the path contains.cspsomewhere.Depends on angular/dgeni-packages#70 to be merged and updated dgeni-packages to be included in angular.js