Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

(doc) ng-repeat animation explanation #9047

Closed
wants to merge 2 commits into from

Conversation

guisouza
Copy link
Contributor

it took a while for me to realize that ng-animate was deprecated and to understand how the animation on this page example works .. so i write a better explanation for this.

it took a while for me to realize that ng-animate was deprecated and to understand how the animation on this page example works .. so i write a better explanation for this.
*
*
* To use animations with ngRepeat you basically just need to write your css transitions appended to
* an class that will be attached to your repeated element.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"[...] appended to a class [...]"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using the word 'element'.
tks

@caitp
Copy link
Contributor

caitp commented Sep 12, 2014

I think there are a few different problems with this:

  1. it's not removing or correcting anything in the docs that you found confusing
  2. it's inaccurate --- ngAnimate does not require animations to be defined in terms of CSS classes, javascript animations are also supported.
  3. there is a demonstration of exactly this behaviour several lines lower, which is runnable and can be copied to plunkr in order to try things with it.

We do want to make the docs better, but this addition might use some work to be beneficial

@caitp
Copy link
Contributor

caitp commented Sep 12, 2014

Second commit looks good though, I will merge that

@caitp
Copy link
Contributor

caitp commented Sep 12, 2014

I'm wrong, can't merge it, that section of the docs was removed :(

@guisouza
Copy link
Contributor Author

" that section of the docs was removed"
are u talking about the #9046 ?

@caitp
Copy link
Contributor

caitp commented Sep 13, 2014

no, I haven't looked at #9046 yet --- the patch for the second commit does not apply, because that section of the docs was removed from ngRepeat at some point

@guisouza
Copy link
Contributor Author

ok ! =]
Thanks for your time and attention.
I appreciate your work!

@caitp
Copy link
Contributor

caitp commented Sep 13, 2014

Oh I'm dumb, didnt realize the second commit was fixing a typo in the first. Anyways if you fix it up a bit it could be helpful maybe

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants