-
Notifications
You must be signed in to change notification settings - Fork 27.4k
(doc) ng-repeat animation explanation #9047
Conversation
it took a while for me to realize that ng-animate was deprecated and to understand how the animation on this page example works .. so i write a better explanation for this.
* | ||
* | ||
* To use animations with ngRepeat you basically just need to write your css transitions appended to | ||
* an class that will be attached to your repeated element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"[...] appended to a class [...]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using the word 'element'.
tks
I think there are a few different problems with this:
We do want to make the docs better, but this addition might use some work to be beneficial |
Second commit looks good though, I will merge that |
I'm wrong, can't merge it, that section of the docs was removed :( |
" that section of the docs was removed" |
no, I haven't looked at #9046 yet --- the patch for the second commit does not apply, because that section of the docs was removed from ngRepeat at some point |
ok ! =] |
Oh I'm dumb, didnt realize the second commit was fixing a typo in the first. Anyways if you fix it up a bit it could be helpful maybe |
02dc2aa
to
fd2d6c0
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
it took a while for me to realize that ng-animate was deprecated and to understand how the animation on this page example works .. so i write a better explanation for this.