Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor(ngModelController): removed redundant this.$validators initialisation #8969

Closed
wants to merge 1 commit into from

Conversation

harrastia
Copy link

Same initialisation already exists two lines above the one removed

@harrastia harrastia changed the title Removed redundant this.$validators initialisation in NgModelController refactor(ngModelController): removed redundant this.$validators initialisation Sep 6, 2014
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@petebacondarwin petebacondarwin added this to the 1.3.0-rc.1 milestone Sep 7, 2014
@petebacondarwin
Copy link
Contributor

@tbosch should include this in his refactoring #8941

@petebacondarwin
Copy link
Contributor

@harrastia - can you please sign the CLA?

@Narretz
Copy link
Contributor

Narretz commented Sep 7, 2014

I checked, this is part of the refactoring in #8941

@tbosch
Copy link
Contributor

tbosch commented Sep 8, 2014

Closing this, as part of #8941 which just landed in master.

@tbosch tbosch closed this Sep 8, 2014
@harrastia
Copy link
Author

Hi, thanks for checking this, i signed the CLA in another (personal) account so will have that ready for any further contributions.

@Narretz
Copy link
Contributor

Narretz commented Sep 10, 2014

That'd good! Contributions are always welcome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants