This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animate): wait two until two digests are over until enabling animations #8846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -412,33 +412,27 @@ angular.module('ngAnimate', ['ng']) | |||
| $rootElement.data(NG_ANIMATE_STATE, rootAnimateState); | |||
|
|
|||
| // disable animations during bootstrap, but once we bootstrapped, wait again | |||
| // for another digest until enabling animations. Enter, leave and move require | |||
| // for another 2 digests until enabling animations. Enter, leave and move require | |||
| // a follow-up digest so having a watcher here is enough to let both digests pass. | |||
| // However, when any directive or view templates are downloaded then we need to | |||
| // handle postpone enabling animations until they are fully completed and then... | |||
| var watchFn = $rootScope.$watch( | |||
There was a problem hiding this comment.
can you call this deregisterWatch instead?
matsko
force-pushed
the
fix_ng_animate_no_templates
branch
from
17092df to
6c51974
Compare
matsko
force-pushed
the
fix_ng_animate_no_templates
branch
from
6c51974 to
fce672d
Compare
…mations Even when no remote templates are to be downloaded, wait until the end of the post digest queue before enabling animations since all $animate-triggered animation events perform a post digest before running animations. Closes angular#8844
matsko
force-pushed
the
fix_ng_animate_no_templates
branch
from
fce672d to
b9c9b94
Compare
|
MERGED as 9257674 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when no remote templates are to be downloaded, wait two digests until
enabling animations since all structural digests perform a post digest before
running animations.
Closes #8844
Broken Example (no remote templates ->
snapshot):http://plnkr.co/edit/LREaTTieMJj4lOPJTjI0?p=preview
Working example (no remote templates ->
this fix):http://plnkr.co/edit/CuigpbMIB4ZkdmhWJ1bO?p=preview
Working example (remote templates ->
snapshot)http://plnkr.co/edit/QLD5TVtWnHGvCLnFcCYw?p=preview
Working example (remote templates ->
this fix)http://plnkr.co/edit/YtjFzsb7bR2AwfXD9lF2?p=preview