Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Browserurlchange #8788

Closed
wants to merge 2 commits into from
Closed

Conversation

jeffbcross
Copy link
Contributor

Pushing for Travis...you know the drill

DUPE of #8785

@jeffbcross
Copy link
Contributor Author

@tbosch Travis is happy now.

For the test that was causing full page reload in IE, I just wrapped the whole test block in a condition to make it not execute if !history.replaceState (since the test was for history.replaceState which isn't supported). Something was causing the page reload when constructing the $browser in that test.

I also added a separate test to test that changing the hash would fail before and succeed after this fix.

@jeffbcross
Copy link
Contributor Author

@tbosch I'm closing this PR; do what you will with my commit.

@jeffbcross jeffbcross closed this Aug 27, 2014
@tbosch
Copy link
Contributor

tbosch commented Aug 27, 2014

Great, thanks for the investigation!
Thought about the test a little more and moved it into browserSpec.js, as there are FakeWindow and FakeDocument that it can use, so we don't need a special case for IE9.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants