Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

$location.search(search, [paramValue]) documentation now reflects that paramValue can be a Number #8773

Closed
wants to merge 1 commit into from

Conversation

johnnyreilly
Copy link
Contributor

I've amended the documentation to reflect that paramValue can also accept a Number as the value to set in the same manner it currently accepts a string. I'm aware of it being used like this at present (without issue that I'm aware of) and so this PR just makes it a recognised usage of the API.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@johnnyreilly
Copy link
Contributor Author

Hi @mary-poppins (have you become self-aware yet? 😄),

I've just signed the CLA (electronically) . I hope all is in order now? Let me know if not...

"Let's go fly a kite..."

@pkozlowski-opensource
Copy link
Member

If we want to make non-string arguments "official" part of the public API then I guess we should merge #7161 as well that enables numbers for the 'path' part

@johnnyreilly
Copy link
Contributor Author

Sounds sensible @pkozlowski-opensource - originally this came up as I was updating the Definitely Typed angular typings and noticed that Number wasn't officially part of the API.

Accordingly I've not included Number in the DT typings for now as we seek to be official-API-compliant. But I can't think of a reason this shouldn't be part of the official API (hence the PR). If this is accepted I'll plan to update the DT typings again to include a search paramValue Number overload.

I suppose the difference between this and #7161 is that this is only a doc change - the code isn't touched.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@johnnyreilly
Copy link
Contributor Author

Thanks @mary-poppins!

@jeffbcross jeffbcross self-assigned this Sep 3, 2014
@jeffbcross jeffbcross added this to the 1.3.0-rc.1 milestone Sep 3, 2014
@jeffbcross
Copy link
Contributor

Landed 48e66cf
Thanks!

@jeffbcross jeffbcross closed this Sep 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants