Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngRepeat): update step_02.ngdoc with challenge #8757

Closed
wants to merge 1 commit into from
Closed

docs(ngRepeat): update step_02.ngdoc with challenge #8757

wants to merge 1 commit into from

Conversation

nicolaiskogheim
Copy link
Contributor

I tried making a 5x5 table using two ng-repeaters. This showed me that it is the element with the ng-repeat attribute on it that gets repeated, and not only the contents of it. Next time I won't be adding the repeater to the table tag :)
Anyway, this is why I propose to add a little challenge to the readers regarding ng-repeat.

@nicolaiskogheim
Copy link
Contributor Author

I see now that I missed some of the guidelines regarding commit messages. To save you the trouble, I'm just going to cancel this thing.

@caitp
Copy link
Contributor

caitp commented Aug 24, 2014

It's no big deal dude, it just takes a quick git commit --amend to fix the message :p I was just waiting to see what other people think about merging it, it's kind of a cute thing to add but not really informative on its own.

@nicolaiskogheim
Copy link
Contributor Author

It was never my intention to add cuteness to your docs.

I think it adds more value to the ng-repeat example over. It's not clear in the example what gets repeated. It may be ok to just say "Note that the get's repeated, not the ", but where's the educational value in that?
I can understand that you might not share my view on this, but then again, you know a lot about angular, and I don't.

@caitp
Copy link
Contributor

caitp commented Aug 24, 2014

take it easy, I'm not saying it's not worth adding, I just wanted to wait for a second opinion =) I'll re-open. I actually like the addition, I'm not sure how that wasn't clear from my first comment :p

@caitp caitp reopened this Aug 24, 2014
@nicolaiskogheim
Copy link
Contributor Author

I'm sorry if I come of as upset or touchy. That's my poor english skills, not me :)

I'll amend the commit message now. Just in case

Add a simple task for the user to better understand ng-repeat.

Close #8757
@nicolaiskogheim nicolaiskogheim changed the title docs: Update step_02.ngdoc with ng-repeat challenge docs(ngRepeat): update step_02.ngdoc with challenge Aug 24, 2014
@btford btford added this to the Backlog milestone Sep 2, 2014
@btford
Copy link
Contributor

btford commented Sep 2, 2014

I don't feel strongly about this either way.

@caitp
Copy link
Contributor

caitp commented Sep 2, 2014

I kind of like it, so if nobody has a serious issue with it I'll merge

@btford
Copy link
Contributor

btford commented Sep 2, 2014

go for it

caitp pushed a commit that referenced this pull request Sep 2, 2014
Add a simple task for the user to better understand ng-repeat.

Close #8757
@caitp caitp closed this in ce25ac8 Sep 2, 2014
@caitp
Copy link
Contributor

caitp commented Sep 2, 2014

merg'd, thanks @nicolaiskogheim

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants