-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(ngRepeat): update step_02.ngdoc with challenge #8757
Conversation
I see now that I missed some of the guidelines regarding commit messages. To save you the trouble, I'm just going to cancel this thing. |
It's no big deal dude, it just takes a quick |
It was never my intention to add cuteness to your docs. I think it adds more value to the ng-repeat example over. It's not clear in the example what gets repeated. It may be ok to just say "Note that the get's repeated, not the ", but where's the educational value in that? |
take it easy, I'm not saying it's not worth adding, I just wanted to wait for a second opinion =) I'll re-open. I actually like the addition, I'm not sure how that wasn't clear from my first comment :p |
I'm sorry if I come of as upset or touchy. That's my poor english skills, not me :) I'll amend the commit message now. Just in case |
Add a simple task for the user to better understand ng-repeat. Close #8757
I don't feel strongly about this either way. |
I kind of like it, so if nobody has a serious issue with it I'll merge |
go for it |
Add a simple task for the user to better understand ng-repeat. Close #8757
merg'd, thanks @nicolaiskogheim |
I tried making a 5x5 table using two ng-repeaters. This showed me that it is the element with the ng-repeat attribute on it that gets repeated, and not only the contents of it. Next time I won't be adding the repeater to the table tag :)
Anyway, this is why I propose to add a little challenge to the readers regarding ng-repeat.