Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs: update module.ngdoc Hello World example #8673

Closed
wants to merge 3 commits into from
Closed

docs: update module.ngdoc Hello World example #8673

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83c2eef
Update module.ngdoc Hello World example
Aug 19, 2014
d567a48
docs: demo ng-app in module.ngdoc Hello World
Aug 19, 2014
202f365
docs(guide/module): update HelloWorld example
Aug 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/content/guide/module.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@ should be bootstrapped. There are several advantages to this approach:

I'm in a hurry. How do I get a Hello World module working?

<example module='myApp'>
<example ng-app-included module='myApp'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've landed a fix for the e2e bugs you were getting. So can I get you to change this very slightly, to make it ng-app-included="true" instead? We need a value, otherwise the template engine doesn't know that there's a value for it.

Also fix the indentation a bit and see if the tests are green, we should be okay to merge it after that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to hear. OK I'll have this ready in a sec...

<file name="index.html">
<div ng-app="myApp">
<div>
{{ 'World' | greet }}
</div>
</div>
</file>

<file name="script.js">
Expand Down