Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs: update module.ngdoc Hello World example #8673

Closed
wants to merge 3 commits into from
Closed

docs: update module.ngdoc Hello World example #8673

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83c2eef
Update module.ngdoc Hello World example
Aug 19, 2014
d567a48
docs: demo ng-app in module.ngdoc Hello World
Aug 19, 2014
202f365
docs(guide/module): update HelloWorld example
Aug 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/content/guide/module.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,11 @@ I'm in a hurry. How do I get a Hello World module working?

<example module='myApp'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add ng-app-included to the <example> tag for this to work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I must be doing something wrong. I updated the commit as suggested but TravisCI is failing..getting this error: Error: No element found using locator: by.binding("{{ 'World' | greet }}")

<file name="index.html">
<html ng-app="myApp">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation is pretty mucked up, can you please fix this and force-push your changes? thanks~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't really use the html tag for this, because the example is already inside an html tag :( need to make it a div or something

<div>
{{ 'World' | greet }}
</div>
</html>
</file>

<file name="script.js">
Expand Down