Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix salt wikipedia link that has parens in the URL #8654

Closed
wants to merge 1 commit into from
Closed

Fix salt wikipedia link that has parens in the URL #8654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ng/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ function $HttpProvider() {
* that only JavaScript running on your domain could have sent the request. The token must be
* unique for each user and must be verifiable by the server (to prevent the JavaScript from
* making up its own tokens). We recommend that the token is a digest of your site's
* authentication cookie with a [salt](https://en.wikipedia.org/wiki/Salt_(cryptography))
* authentication cookie with a [salt](https://en.wikipedia.org/wiki/Salt_%28cryptography%29)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not use percent encoding, but entity references instead, so that the attribute has a nicer value --- you only need to convert the right parentheses to ) instead, the left one is fine on its own.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Thanks for the comment and for fixing it

* for added security.
*
* The name of the headers can be specified using the xsrfHeaderName and xsrfCookieName
Expand Down