Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update route.js: template(Url) is required #8604

Closed
wants to merge 1 commit into from

Conversation

wheatking
Copy link

Just using a 'controller' property alone does not work, a templateUrl (even an empty string) must be set as a property as well.

Review on Reviewable

Just using a 'controller' property alone does not work, a templateUrl (even an empty string) must be set as a property as well.
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@btford
Copy link
Contributor

btford commented Aug 19, 2014

I think a better fix would be for $routeProvider.when to throw if you configure a route with a controller but not a template.

@btford btford added this to the Backlog milestone Aug 19, 2014
@wheatking
Copy link
Author

I agree, that would reveal the problem in practice for the case where
people don't fully read the documentation.

On Tue, Aug 19, 2014 at 2:54 PM, Brian Ford [email protected]
wrote:

I think a better fix would be for $routeProvider.when to throw if you
configure a route with a controller but not a template.


Reply to this email directly or view it on GitHub
#8604 (comment).

@bhollan
Copy link

bhollan commented Jun 30, 2015

It still looks to me like your CLA is still not present, @wheatking .

Is somebody else working on this, or should it be closed? @btford ?

@wheatking
Copy link
Author

I have signed the CLA, but haven't been actively working with angular for a while, so I'm not sure this is relevant anymore.

@Narretz Narretz changed the title Update route.js Update route.js: template(Url) is required Jan 19, 2016
@Narretz Narretz closed this in d80cdeb Nov 4, 2016
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants