-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Update route.js: template(Url) is required #8604
Conversation
Just using a 'controller' property alone does not work, a templateUrl (even an empty string) must be set as a property as well.
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
I think a better fix would be for |
I agree, that would reveal the problem in practice for the case where On Tue, Aug 19, 2014 at 2:54 PM, Brian Ford [email protected]
|
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
It still looks to me like your CLA is still not present, @wheatking . Is somebody else working on this, or should it be closed? @btford ? |
I have signed the CLA, but haven't been actively working with angular for a while, so I'm not sure this is relevant anymore. |
Just using a 'controller' property alone does not work, a templateUrl (even an empty string) must be set as a property as well.