fix(select): Clarify documentation and add exception for ngOptions #8544
Conversation
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
ngOptions introduced `track by` in c32a859. Using `track by` puts constraints on the value you can use in the interpolation expression in ngOptions. This patch both documents this and adds an exception if you use ngOptions in an unsupported way. Closes angular#6564
janv
changed the title
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
|
I like this, but I think I'd prefer this be split into two commits:
I think the implementation change is more of a "feature" or breaking change, whereas the docs change can easily land in |
ngOptions introduced
track byin c32a859.Using
track byputs constraints on the value you can use in the interpolation expression in ngOptions.This patch both documents this and adds an exception if you use ngOptions in an unsupported way.
Closes #6564