-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
Self closing <a> tags in the examples given make no sense because they won't show up in the browser (and I think aren't even allowed according to HTML specs). I've seen this confuse people over at stackoverflow.com who tried to copy/paste those examples.
well, it is technically legal HTML (i'm not saying it should be, these crazy rules on the HTML parser are absolutely bonkers). (what's happening here is that, given the parser insertion rules for anchor tags, the For instance: http://jsfiddle.net/ke879/ I think the main reason why there's no text node within the anchor is to emphasize what the example is actually showing, which is to use I don't have reservations about making this better, though. |
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
Well, I'm not mortally offended if you don't agree with my suggestion, but a short statement why you closed this would be a polite thing to do. |
@paranoidandroid522 he merged it =) |
Oh - in that case, I take it all back :-). I don't have much experience with GitHub yet, I thought "Closed with unmerged commits" means "rejected" ;-). |
It was closed by 833e60a (with the |
Got it. BTW, thanks for your comment about HTML parsing rules. You never stop learning when it comes to web technologies ;-). |
Self closing
<a>
tags in the examples given make no sense because they won't show up in the browser (and I think aren't even allowed according to HTML specs). I've seen this confuse people over at stackoverflow.com who tried to copy/paste those examples.