Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update attrs.js #8488

Closed
wants to merge 1 commit into from
Closed

Update attrs.js #8488

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 5, 2014

Self closing <a> tags in the examples given make no sense because they won't show up in the browser (and I think aren't even allowed according to HTML specs). I've seen this confuse people over at stackoverflow.com who tried to copy/paste those examples.

Self closing <a> tags in the examples given make no sense because they won't show up in the browser (and I think aren't even allowed according to HTML specs). I've seen this confuse people over at stackoverflow.com who tried to copy/paste those examples.
@caitp
Copy link
Contributor

caitp commented Aug 5, 2014

well, it is technically legal HTML (i'm not saying it should be, these crazy rules on the HTML parser are absolutely bonkers). (what's happening here is that, given the parser insertion rules for anchor tags, the <br> and subsequent <a> tags are moved out. In HTML, the XML-style self-closing tags don't really exist, so <a href="whatever" /> is actually <a href="whatever" /="">)

For instance: http://jsfiddle.net/ke879/

I think the main reason why there's no text node within the anchor is to emphasize what the example is actually showing, which is to use ng-href when interpolating urls.

I don't have reservations about making this better, though.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@ghost
Copy link
Author

ghost commented Aug 6, 2014

Well, I'm not mortally offended if you don't agree with my suggestion, but a short statement why you closed this would be a polite thing to do.

@caitp
Copy link
Contributor

caitp commented Aug 6, 2014

@paranoidandroid522 he merged it =)

@ghost
Copy link
Author

ghost commented Aug 6, 2014

Oh - in that case, I take it all back :-). I don't have much experience with GitHub yet, I thought "Closed with unmerged commits" means "rejected" ;-).

@caitp
Copy link
Contributor

caitp commented Aug 6, 2014

It was closed by 833e60a (with the Closes <issue#> line) --- it's in master

@ghost
Copy link
Author

ghost commented Aug 6, 2014

Got it. BTW, thanks for your comment about HTML parsing rules. You never stop learning when it comes to web technologies ;-).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants