This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test(select): relax test for IE8 bug #8465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in IE8 (http://support.microsoft.com/kb/829907 and http://yuilibrary.com/forum-archive/forum/viewtopic.php@p=14826.html): when you clone an `<option>` element the selected attribute on the options can become invalid. This is not relevant to the proper behaviour of the `select` directive since it uses `prop` not `attr` to store the selected status of each option. This test is only interested in there being at least on option with the `selected` attribute, for conformance to accessibility guidelines. So we can safely relax the test to check this rather than concerning ourselves with which option actually has this attribute.
petebacondarwin
added a commit
that referenced
this pull request
Aug 3, 2014
There is a bug in IE8 (http://support.microsoft.com/kb/829907 and http://yuilibrary.com/forum-archive/forum/viewtopic.php@p=14826.html): when you clone an `<option>` element the selected attribute on the options can become invalid. This is not relevant to the proper behaviour of the `select` directive since it uses `prop` not `attr` to store the selected status of each option. This test is only interested in there being at least on option with the `selected` attribute, for conformance to accessibility guidelines. So we can safely relax the test to check this rather than concerning ourselves with which option actually has this attribute. Fixes 79538af Closes #8465
petebacondarwin
added a commit
that referenced
this pull request
Aug 3, 2014
There is a bug in IE8 (http://support.microsoft.com/kb/829907 and http://yuilibrary.com/forum-archive/forum/viewtopic.php@p=14826.html): when you clone an `<option>` element the selected attribute on the options can become invalid. This is not relevant to the proper behaviour of the `select` directive since it uses `prop` not `attr` to store the selected status of each option. This test is only interested in there being at least on option with the `selected` attribute, for conformance to accessibility guidelines. So we can safely relax the test to check this rather than concerning ourselves with which option actually has this attribute. Fixes 79538af Closes #8465
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in IE8 (http://support.microsoft.com/kb/829907 and
http://yuilibrary.com/forum-archive/forum/viewtopic.php@p=14826.html):
when you clone an
<option>element the selected attribute on the optionscan become invalid.
This is not relevant to the proper behaviour of the
selectdirectivesince it uses
propnotattrto store the selected status of eachoption.
This test is only interested in there being at least on option with
the
selectedattribute, for conformance to accessibility guidelines.So we can safely relax the test to check this rather than concerning
ourselves with which option actually has this attribute.