Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(jqLite): fix regression where mutating the dom tree on a event breaks jqLite.remove #8359

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/jqLite.js
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ function jqLiteDealoc(element, onlyDescendants){

if (element.childNodes && element.childNodes.length) {
// we use querySelectorAll because documentFragments don't have getElementsByTagName
var descendants = element.getElementsByTagName ? element.getElementsByTagName('*') :
var descendants = element.getElementsByTagName ? sliceArgs(element.getElementsByTagName('*')) :
element.querySelectorAll ? element.querySelectorAll('*') : [];
for (var i = 0, l = descendants.length; i < l; i++) {
jqLiteRemoveData(descendants[i]);
Expand Down
10 changes: 10 additions & 0 deletions test/jqLiteSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,16 @@ describe('jqLite', function() {
browserTrigger(span);
expect(log).toEqual('click;');
});

it('should work if the descendants of the element change while it\'s being removed', function() {
var div = jqLite('<div><p><span>text</span></p></div>');
div.find('p').on('$destroy', function() {
div.find('span').remove();
});
expect(function() {
div.remove();
}).not.toThrow();
});
});
});

Expand Down