feat($interpolate): use custom toString member if present #8350

danielkrainas · 2014-07-26T01:44:03Z

BREAKING CHANGE: use custom toString implementation when present on object value types.
Behavior is consistent with other implementations.

Closes #7317

mary-poppins · 2014-07-26T01:44:06Z

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

Uses the issue template (#8350)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

petebacondarwin · 2014-07-26T19:05:14Z

src/ng/interpolate.js

@@ -272,7 +272,11 @@ function $InterpolateProvider() {
              break;
            }
            default: {
-              value = toJson(value);
+              if(typeof value.toString !== 'undefined' && value != null && value.toString !== Object.prototype.toString && !isArray(value)) {


we have an isFunction() method:

if (isFunction(value.toString)) { value = value.toString(); } else { value = toJson(value); }

petebacondarwin · 2014-07-26T19:06:43Z

@danielkrainas - I am not sure if this will be accepted but you would help your case by including unit tests and also

Behavior is consistent with other implementations.
providing links to these other implementations.

Adding to the IceBox for the moment as that is where the original issue is to be found.

BREAKING CHANGE: use custom toString implementation when present on object value types. Behavior is consistent with implementations found in other languages such as Ruby, Python, and CoffeeScript. http://rubymonk.com/learning/books/1-ruby-primer/chapters/5-strings/lessons/31-string-basics https://docs.python.org/2/library/stdtypes.html#string-formatting-operations http://coffeescriptcookbook.com/chapters/strings/interpolation Closes angular#7317

danielkrainas · 2014-07-28T21:45:44Z

@petebacondarwin I've included a couple tests and added links to relevant sources.

This behavior is consistent with implementations found in other languages such as Ruby, Python, and CoffeeScript. http://rubymonk.com/learning/books/1-ruby-primer/chapters/5-strings/lessons/31-string-basics https://docs.python.org/2/library/stdtypes.html#string-formatting-operations http://coffeescriptcookbook.com/chapters/strings/interpolation Fixes angular#7317 Closes angular#8350 BREAKING CHANGE: When converting values to strings, interpolation now uses a custom toString() function on objects that are not numbers, dates or arrays (custom means that the `toString()` function is not the same as `Object.prototype.toString()`). Otherwise, interpolation uses JSON.stringify() as usual. Should you have a custom toString() function but still want the output of JSON.stringify(), migrate as shown in the following examples: Before: ```html {{myObject}} ``` After - use the `json` filter to stringify the object: ```html {{myObject | json}} ```

This behavior is consistent with implementations found in other languages such as Ruby, Python, and CoffeeScript. http://rubymonk.com/learning/books/1-ruby-primer/chapters/5-strings/lessons/31-string-basics https://docs.python.org/2/library/stdtypes.html#string-formatting-operations http://coffeescriptcookbook.com/chapters/strings/interpolation Fixes angular#7317 Closes angular#8350 BREAKING CHANGE: When converting values to strings, interpolation now uses a custom toString() function on objects that are not numbers or arrays (custom means that the `toString()` function is not the same as `Object.prototype.toString()`). Otherwise, interpolation uses JSON.stringify() as usual. Should you have a custom toString() function but still want the output of JSON.stringify(), migrate as shown in the following examples: Before: ```html {{myObject}} ``` After - use the `json` filter to stringify the object: ```html {{myObject | json}} ``` fixup

@danielkrainas

Except on Numbers, Dates and Arrays. Thanks to @danielkrainas for the initial implementation of this feature. This behavior is consistent with implementations found in other languages such as Ruby, Python, and CoffeeScript. http://rubymonk.com/learning/books/1-ruby-primer/chapters/5-strings/lessons/31-string-basics https://docs.python.org/2/library/stdtypes.html#string-formatting-operations http://coffeescriptcookbook.com/chapters/strings/interpolation The commit also exposes a private $$stringify method on the angular global, so that ngMessageFormat can use the same logic without duplicating it. Fixes angular#7317 Closes angular#8350 BREAKING CHANGE: When converting values to strings, interpolation now uses a custom toString() function on objects that are not Number, Array or Date (custom means that the `toString()` function is not the same as `Object.prototype.toString()`). Otherwise, interpolation uses JSON.stringify() as usual. Should you have a custom toString() function but still want the output of JSON.stringify(), migrate as shown in the following examples: Before: ```html {{myObject}} ``` After - use the `json` filter to stringify the object: ```html {{myObject | json}} ```

@danielkrainas

Except on Numbers, Dates and Arrays. Thanks to @danielkrainas for the initial implementation of this feature. This behavior is consistent with implementations found in other languages such as Ruby, Python, and CoffeeScript. http://rubymonk.com/learning/books/1-ruby-primer/chapters/5-strings/lessons/31-string-basics https://docs.python.org/2/library/stdtypes.html#string-formatting-operations http://coffeescriptcookbook.com/chapters/strings/interpolation The commit also exposes a private $$stringify method on the angular global, so that ngMessageFormat can use the same logic without duplicating it. Fixes angular#7317 Closes angular#8350 BREAKING CHANGE: When converting values to strings, interpolation now uses a custom toString() function on objects that are not Number, Array or Date (custom means that the `toString()` function is not the same as `Object.prototype.toString()`). Otherwise, interpolation uses JSON.stringify() as usual. Should you have a custom toString() function but still want the output of JSON.stringify(), migrate as shown in the following examples: Before: ```html {{myObject}} ``` After - use the `json` filter to stringify the object: ```html {{myObject | json}} ```

@danielkrainas

Except on Numbers, Dates and Arrays. Thanks to @danielkrainas for the initial implementation of this feature. This behavior is consistent with implementations found in other languages such as Ruby, Python, and CoffeeScript. http://rubymonk.com/learning/books/1-ruby-primer/chapters/5-strings/lessons/31-string-basics https://docs.python.org/2/library/stdtypes.html#string-formatting-operations http://coffeescriptcookbook.com/chapters/strings/interpolation The commit also exposes a private $$stringify method on the angular global, so that ngMessageFormat can use the same logic without duplicating it. Fixes angular#7317 Closes angular#8350 BREAKING CHANGE: When converting values to strings, interpolation now uses a custom toString() function on objects that are not Number, Array or Date (custom means that the `toString()` function is not the same as `Object.prototype.toString()`). Otherwise, interpolation uses JSON.stringify() as usual. Should you have a custom toString() function but still want the output of JSON.stringify(), migrate as shown in the following examples: Before: ```html {{myObject}} ``` After - use the `json` filter to stringify the object: ```html {{myObject | json}} ```

@danielkrainas

Except on Numbers, Dates and Arrays. Thanks to @danielkrainas for the initial implementation of this feature. This behavior is consistent with implementations found in other languages such as Ruby, Python, and CoffeeScript. http://rubymonk.com/learning/books/1-ruby-primer/chapters/5-strings/lessons/31-string-basics https://docs.python.org/2/library/stdtypes.html#string-formatting-operations http://coffeescriptcookbook.com/chapters/strings/interpolation The commit also exposes a private $$stringify method on the angular global, so that ngMessageFormat can use the same logic without duplicating it. Fixes angular#7317 Closes angular#8350 Fixes angular#11406 BREAKING CHANGE: When converting values to strings, interpolation now uses a custom toString() function on objects that are not Number, Array or Date (custom means that the `toString` function is not the same as `Object.prototype.toString`). Otherwise, interpolation uses JSON.stringify() as usual. Should you have a custom toString() function but still want the output of JSON.stringify(), migrate as shown in the following examples: Before: ```html {{myObject}} ``` After - use the `json` filter to stringify the object: ```html {{myObject | json}} ```

danielkrainas added cla: yes and removed cla: no labels Jul 26, 2014

petebacondarwin reviewed Jul 26, 2014
View reviewed changes

petebacondarwin added this to the Ice Box milestone Jul 26, 2014

petebacondarwin added component: misc core and removed needs: public api labels Jul 26, 2014

btford removed the gh: PR label Aug 20, 2014

caitp force-pushed the master branch from 591bac5 to d713ad1 Compare August 22, 2014 13:51

tbosch force-pushed the master branch from 6c27b89 to 271572c Compare August 30, 2014 00:57

tbosch force-pushed the master branch from a3d7934 to 1418383 Compare September 10, 2014 18:14

petebacondarwin force-pushed the master branch from 02dc2aa to fd2d6c0 Compare September 16, 2014 11:26

jeffbcross force-pushed the master branch 2 times, most recently from cad9560 to f294244 Compare October 2, 2014 22:09

btford force-pushed the master branch from 9011a65 to 46db47b Compare October 6, 2014 22:54

jeffbcross force-pushed the master branch 4 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:37

petebacondarwin force-pushed the master branch from 4dd5a20 to 998c61c Compare October 19, 2014 10:57

Narretz force-pushed the master branch from 70049ae to b77e14b Compare January 16, 2016 21:59

Narretz mentioned this pull request Jun 5, 2016

fix($interpolate): use custom toString() function & fix(ngBind): use same json conversion as $interpolate #14715

Merged

3 tasks

Narretz added the needs: breaking change label Jun 8, 2016

Narretz closed this in a5fd2e4 Jun 28, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat($interpolate): use custom toString member if present #8350

feat($interpolate): use custom toString member if present #8350

danielkrainas commented Jul 26, 2014

mary-poppins commented Jul 26, 2014

petebacondarwin Jul 26, 2014

petebacondarwin commented Jul 26, 2014

danielkrainas commented Jul 28, 2014

feat($interpolate): use custom toString member if present #8350

feat($interpolate): use custom toString member if present #8350

Conversation

danielkrainas commented Jul 26, 2014

mary-poppins commented Jul 26, 2014

petebacondarwin Jul 26, 2014

Choose a reason for hiding this comment

petebacondarwin commented Jul 26, 2014

danielkrainas commented Jul 28, 2014