Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(Scope): clarify naming in the $watch example #8271

Closed

Conversation

pkozlowski-opensource
Copy link
Member

Fixes #8254

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8271)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

function() { return food; },
// This is the change handler
// This is the change listener, called when the value returned from the above function changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internally, this function is sometimes called the watchAction, but change listener makes sense in this example.

@Narretz Narretz added this to the 1.3.0-beta.17 milestone Jul 21, 2014
@petebacondarwin petebacondarwin self-assigned this Jul 23, 2014
@petebacondarwin
Copy link
Contributor

LGTM although I would check the line lengths :-)

@pkozlowski-opensource
Copy link
Member Author

@petebacondarwin I guess we should have a rule in jshint / jscs to check for the line length if we want to enforce those, otherwise there will be always someone not prudent enough :-)

@caitp
Copy link
Contributor

caitp commented Jul 24, 2014

I believe we are enforcing a 200 col limit, globally.

@petebacondarwin
Copy link
Contributor

Oh I thought it was 100
On 24 Jul 2014 18:15, "Caitlin Potter" [email protected] wrote:

I believe we are enforcing a 200 col limit, globally.


Reply to this email directly or view it on GitHub
#8271 (comment).

@caitp
Copy link
Contributor

caitp commented Jul 24, 2014

I think you should try to keep code under 100 cols, but jshint-base in the root of the tree has maxlen: 200 and is inherited by all of the different sub-configs in the tree.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The comments display the wrong place in api reference
6 participants