Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngValue) Replace input[select] with option for clarity #8203

Closed

Conversation

timraymond
Copy link
Contributor

Request Type: docs

How to reproduce:

Component(s): forms

Impact:

Complexity: small

This issue is related to:

Detailed Description:

It is impossible to create an input[select], so it appears the intention
here was actually option.

While ngOptions would probably be easier to use in most cases, someone may have a use case for using ngValue with option which is why I decided to change it in lieu of deleting it, as had been mentioned in the issue.

Other Comments:

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8203)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

It is impossible to create an `input[select]`, so it appears the intention
here was actually `option`.

Fixes angular#7994
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Narretz Narretz added this to the 1.3.0 milestone Jul 16, 2014
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants